Fix/attuation handling amplified mode#119
Open
TorbjornRasmussenQM wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Attenuation handling in amplified previously used bit shifting to calculate the output, but this is wrong for amplified mode, instead it uses simple multiplication now, I did not discover any additional latency from this change.
Type of Change
Related Issues
Checklist
Code Quality
pre-commithooks and all checks pass (pre-commit run --all-files)Testing
pytest)Documentation
Breaking Changes
Does this PR introduce breaking changes?
Testing Details
Tests are added to
tests_against_server/voltage_gate_sequence/test_attenuation_amplified.pyScreenshots/Examples
Additional Context
Reviewer Notes