Skip to content

Fix/attuation handling amplified mode#119

Open
TorbjornRasmussenQM wants to merge 8 commits into
release/nightlyfrom
fix/attuation_handling_amplified_mode
Open

Fix/attuation handling amplified mode#119
TorbjornRasmussenQM wants to merge 8 commits into
release/nightlyfrom
fix/attuation_handling_amplified_mode

Conversation

@TorbjornRasmussenQM

Copy link
Copy Markdown
Contributor

Pull Request

Description

Attenuation handling in amplified previously used bit shifting to calculate the output, but this is wrong for amplified mode, instead it uses simple multiplication now, I did not discover any additional latency from this change.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ✅ Test addition/update
  • 🎨 Code style/formatting update

Related Issues

Checklist

Code Quality

  • My code follows the project's style guidelines
  • I have run pre-commit hooks and all checks pass (pre-commit run --all-files)
  • My commits follow the Conventional Commits format
  • I have performed a self-review of my code
  • My changes generate no new warnings

Testing

  • I have added tests that prove my fix/feature works
  • All new and existing tests pass locally (pytest)
  • I have tested my changes with the example scripts (if applicable)

Documentation

  • I have updated the documentation (if needed)
  • I have added docstrings to new functions/classes
  • I have updated the CHANGELOG.md (if applicable)
  • I have checked my code and corrected any misspellings

Breaking Changes

Does this PR introduce breaking changes?

Testing Details

Tests are added to tests_against_server/voltage_gate_sequence/test_attenuation_amplified.py

Screenshots/Examples

Additional Context

Reviewer Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant